xds: make it possible to create a StringMatcher from arguments outside of test code#8723
Merged
easwars merged 3 commits intogrpc:masterfrom Nov 26, 2025
Merged
xds: make it possible to create a StringMatcher from arguments outside of test code#8723easwars merged 3 commits intogrpc:masterfrom
easwars merged 3 commits intogrpc:masterfrom
Conversation
easwars
added
Area: xDS
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8723 +/- ##
==========================================
- Coverage 83.21% 83.18% -0.03%
==========================================
Files 419 419
Lines 32427 32450 +23
==========================================
+ Hits 26985 26995 +10
- Misses 4054 4064 +10
- Partials 1388 1391 +3
🚀 New features to boost your workflow:
|
arjan-bal
reviewed
Nov 25, 2025
arjan-bal
approved these changes
Nov 26, 2025
| matcher.StringMatcherForTesting(nil, nil, nil, newStringP("2001:db8:1:1::68"), nil, false), | ||
| matcher.StringMatcherForTesting(nil, nil, nil, newStringP("GRPC"), nil, false), | ||
| matcher.NewContainsStringMatcher("i-aint-the-one", false), | ||
| matcher.NewContainsStringMatcher("2001::db8:1:1::68", false), |
Contributor
There was a problem hiding this comment.
nit: The double colon in 2001:: makes the IPv6 invalid. It doesn't effect the test, but seems like an unintended change which can be reverted.
Contributor
Author
There was a problem hiding this comment.
Oops. Looks like a copy paste mistake.
This was referenced Apr 23, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
ignore_casefield, but was.RELEASE NOTES:
StringMatcherwhere regexes would match incorrectly when ignore_case is set to true.